Fix array distinct rule for objects that have null/undefined items#148
Merged
Conversation
Contributor
|
Looks good. Thanks! Can you also update the docs to mention that not only the missing keys, the objects with https://vinejs.dev/docs/types/array#treatment-of-objects-with-missing-keys |
2 tasks
Contributor
Author
|
Sure thing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❓ Type of change
📚 Description
Hi!
I noticed that
helpers.isDistinct()doesn't currently ignorenullandundefinedvalues when checking uniqueness for arrays of objects, even though the documentation states that they should be ignored.For example:
with:
{ "variants": [ { "sku": null }, { "sku": null } ] }currently fails with a "sku is not unique" error because null values are converted to the same key during the uniqueness check.
I've updated the implementation to skip uniqueness checks whenever one or more of the fields used to build the composite key are
nullorundefined, matching the documented behavior and the implementation for primitive arrays.I've opened this PR to fix that inconsistency.