-
-
Notifications
You must be signed in to change notification settings - Fork 32
feat: improvements to ruff and new python 3.15 #255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for Python 3.15 alpha testing and modernizes the ruff linting setup by switching from a pip-installed version to using uvx for direct execution.
- Added Python 3.15.0-alpha.1 to the CI test matrix
- Removed separate ruff installation step in favor of using
uvxto run ruff directly
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #255 +/- ##
=======================================
Coverage 99.30% 99.30%
=======================================
Files 3 3
Lines 288 288
=======================================
Hits 286 286
Misses 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR extends the GitHub Actions CI to test against Python 3.15 alpha and streamlines the ruff linting workflow by removing its separate installation and leveraging uvx for direct execution. Flow diagram for updated ruff linting step in CIflowchart TD
A["Install dependencies with uv"] --> B["Run ruff using uvx"]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- Add an explicit step to install or pin uvx before calling 'uvx ruff' so the CI won’t fail if uvx isn’t already available.
- Combine the two 'uv pip install' commands into one to reduce redundant installs and speed up the workflow.
- Consider marking the Python 3.15 alpha job as allowed-to-fail in the matrix since alpha releases can break unpredictably.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Add an explicit step to install or pin uvx before calling 'uvx ruff' so the CI won’t fail if uvx isn’t already available.
- Combine the two 'uv pip install' commands into one to reduce redundant installs and speed up the workflow.
- Consider marking the Python 3.15 alpha job as allowed-to-fail in the matrix since alpha releases can break unpredictably.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This PR adds support for Python 3.15 alpha testing and modernizes the ruff linting setup by switching from a pip-installed version to using uvx for direct execution.
Added Python 3.15.0-alpha.1 to the CI test matrix
Removed separate ruff installation step in favor of using uvx to run ruff directly
Summary by Sourcery
Add support for Python 3.15 alpha in CI and modernize Ruff linting by running it through uvx instead of a separate installation
CI: