improve some types on phpdoc - #190
Merged
Merged
Conversation
Owner
|
Thanks for the pull request Tomoki! Maybe should we drop the blocks on the class and rely just on the ones from the interface instead? Like we do with the math interface. |
Contributor
Author
|
@vinkla yes, it makes the phpdoc block cleaner :) |
Owner
|
Great! Would you mind removing the blocks in this PR? |
vinkla
reviewed
Feb 23, 2023
vinkla
reviewed
Feb 23, 2023
Contributor
Author
|
i pushed again because I included unnecessary commits. would this be ok? |
Owner
|
Looks good! Thanks 🙌 |
Contributor
|
This is a great PR. |
stof
reviewed
Feb 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed a mistake in the type of the argument of the encode method. also, there was an error in the return value type of the decode method, so I fixed it.
array{}means an empty array. this is fine without it, but it makes it explicit that an empty array can also be returned. you can remove it if you don't like it.