Skip to content

improve some types on phpdoc - #190

Merged
vinkla merged 4 commits into
vinkla:masterfrom
jamband:patch-1
Feb 23, 2023
Merged

improve some types on phpdoc#190
vinkla merged 4 commits into
vinkla:masterfrom
jamband:patch-1

Conversation

@jamband

@jamband jamband commented Feb 23, 2023

Copy link
Copy Markdown
Contributor

fixed a mistake in the type of the argument of the encode method. also, there was an error in the return value type of the decode method, so I fixed it.

array{} means an empty array. this is fine without it, but it makes it explicit that an empty array can also be returned. you can remove it if you don't like it.

@vinkla

vinkla commented Feb 23, 2023

Copy link
Copy Markdown
Owner

Thanks for the pull request Tomoki!

Maybe should we drop the blocks on the class and rely just on the ones from the interface instead? Like we do with the math interface.

@jamband

jamband commented Feb 23, 2023

Copy link
Copy Markdown
Contributor Author

@vinkla yes, it makes the phpdoc block cleaner :)

@vinkla

vinkla commented Feb 23, 2023

Copy link
Copy Markdown
Owner

Great! Would you mind removing the blocks in this PR?

Comment thread src/Hashids.php Outdated
Comment thread src/Hashids.php Outdated
@jamband

jamband commented Feb 23, 2023

Copy link
Copy Markdown
Contributor Author

i pushed again because I included unnecessary commits. would this be ok?

@vinkla

vinkla commented Feb 23, 2023

Copy link
Copy Markdown
Owner

Looks good! Thanks 🙌

@vinkla
vinkla merged commit 818404c into vinkla:master Feb 23, 2023
@szepeviktor

Copy link
Copy Markdown
Contributor

This is a great PR.

Comment thread src/HashidsInterface.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants