Merged
Conversation
Renamed _getStorage to _getState
…xtensions that implement specific function selectors, erc165 is refactored into an extension
…nciation [SOL66-1] Fix ownership renounciation
…terfaces as both interfaceIds and function selectors implemented
…rage instead of _getState
…, also removed redundant boolean checks
[SOL66-19] Removed unused imports on Extendable.sol
[SOL66-7] Ensure proper _afterFallback hook call
[SOL66-20] Use cached array length in for loops
…actory, test, task
…IExtension interface
…il due to badly formatted return
…on implementation interface
…ng, and retract tests now all pass
…o extension exists
…mentedInterfaceIds
Feature/extension interfaces
…separating caller from extension
Feature/comprehensive events
ra-phael
approved these changes
Aug 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.2.0 Changelog
Major changes to the Extendable pattern to improve gas cost efficiency and better runtime introspection. Solves problem of function shadowing and refactored ERC165 implementation away from Extension.
Extension implementation now slightly changed.
Some bug fixes.
Implemented enhancements and fixes as suggested by auditors.
Added
Changed
_getStorage=>_getStateIExtensioninterface consisting ofgetInterfaceandgetSolidityInterfacefunctions._beforeFallbackandafterFallbackare now correctly placed to avoid certain conditions where they were not atomicgetCurrentInterface=>getFullInterfaceinitRemoved