Bump library/node from 24-alpine to 26-alpine#4
Merged
Conversation
dependabot
Bot
added
dependencies
Bumps library/node from 24-alpine to 26-alpine. --- updated-dependencies: - dependency-name: library/node dependency-version: 26-alpine dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/docker/library/node-26-alpine
branch
from
4c1c7cd to
a3a3c2a
Compare
tibroc
added a commit
that referenced
this pull request
Jul 1, 2026
…ghts read Addresses code-review findings on the search feature: - #1 (correctness): user queries were interpolated raw into ilike '%'||q||'%', so % and _ acted as SQL wildcards (e.g. "%" returned arbitrary services). Escape LIKE metacharacters in SQL (a small CTE) so the term matches literally; @q stays raw for trigram similarity. Escaping lives in the query, so both the HTTP handler and the read-only catalog MCP are covered with no duplication. - #2 (UX): server-side search can fail, unlike the old client-side filter. A failed /api/search left data undefined and the "Searching…" spinner stuck forever. Add an isError branch that shows an error message instead. - #4 (one use-case layer): the zero-result insights read (days/limit clamp + row→DTO mapping + the SearchInsight struct) was duplicated in the HTTP handler and the MCP manager. Consolidate into service.ListSearchInsights; both paths are now thin wrappers (CLAUDE.md rule 3). Tests: search integration test now asserts '%' and '_' are matched literally (return nothing, not everything). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
tibroc
added a commit
that referenced
this pull request
Jul 1, 2026
…ghts read Addresses code-review findings on the search feature: - #1 (correctness): user queries were interpolated raw into ilike '%'||q||'%', so % and _ acted as SQL wildcards (e.g. "%" returned arbitrary services). Escape LIKE metacharacters in SQL (a small CTE) so the term matches literally; @q stays raw for trigram similarity. Escaping lives in the query, so both the HTTP handler and the read-only catalog MCP are covered with no duplication. - #2 (UX): server-side search can fail, unlike the old client-side filter. A failed /api/search left data undefined and the "Searching…" spinner stuck forever. Add an isError branch that shows an error message instead. - #4 (one use-case layer): the zero-result insights read (days/limit clamp + row→DTO mapping + the SearchInsight struct) was duplicated in the HTTP handler and the MCP manager. Consolidate into service.ListSearchInsights; both paths are now thin wrappers (CLAUDE.md rule 3). Tests: search integration test now asserts '%' and '_' are matched literally (return nothing, not everything). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps library/node from 24-alpine to 26-alpine.