vtk-wasm: move build to virtualcell/vcell-vtk-wasm; consume the release - #1824
Open
jcschaff wants to merge 1 commit into
Open
vtk-wasm: move build to virtualcell/vcell-vtk-wasm; consume the release#1824jcschaff wants to merge 1 commit into
jcschaff wants to merge 1 commit into
Conversation
…elease The custom VTK.wasm build and its golden-test gate now live in the dedicated repo virtualcell/vcell-vtk-wasm, which publishes the bundle as a GitHub Release asset. Repoint the monorepo to consume that release instead of duplicating the build: - Remove build.sh, Dockerfile, patches/, and the vtk-wasm-build.yml workflow (they live in vcell-vtk-wasm now). - tools/vtk-wasm/README.md -> a pointer to the dedicated repo + the release URL. - tools/vtk-wasm/test/ (golden-file test) now DOWNLOADS the pinned release bundle (BUNDLE_TAG, default v1.0.0) and validates the artifact VCell actually consumes, instead of requiring a local build. BUNDLE_TARGZ still overrides for local runs. webapp-ng runtime consumption of the release (the field-viewer wiring) is a separate follow-up. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CMxhE4gyPPRncpMPrRxnBW
jcschaff
marked this pull request as ready for review
August 3, 2026 21:03
Member
Author
|
Verified against the published v1.0.0 release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The custom VTK.wasm build and its golden-test gate now live in a dedicated repo, virtualcell/vcell-vtk-wasm, which builds the bundle and publishes it as a GitHub Release asset. This repoints the monorepo to consume that release instead of duplicating the heavy build.
Changes
tools/vtk-wasm/:build.sh,Dockerfile,patches/, and thevtk-wasm-build.ymlworkflow — they live invcell-vtk-wasmnow.tools/vtk-wasm/README.md→ a pointer to the dedicated repo + the release URL.tools/vtk-wasm/test/(the golden-file test) now downloads the pinned release bundle (BUNDLE_TAG, defaultv1.0.0) and validates the artifact VCell actually consumes — no local build required.BUNDLE_TARGZstill overrides for local runs.The release download URL:
Draft — why
The
v1.0.0release is being built + published byvcell-vtk-wasmright now (build → golden-test gate → release). Once it's published I'll:node tools/vtk-wasm/test/run-golden-test.mjs),Not in this PR
webapp-ngruntime consumption of the release (the field-viewer wiring) is a separate follow-up — this PR is just the build-repoint + consumer-side test.Test-only / tooling change; no runtime VCell code.
🤖 Generated with Claude Code