Stop reporting skipped deploy jobs as failures - #1977
Merged
Conversation
site_deploy's 'Archive to Zenodo' runs only for vcell_site == 'rel' (site_deploy.yml:383), so
every stage and alpha deploy skips it -- and the script printed
FAILED: Archive to Zenodo
on a deploy that had in fact succeeded, because the filter treated any conclusion that was
neither success nor null as a failure. It cost me a detour into a Zenodo job that was working
exactly as designed, on a release that was fine.
A false alarm on every non-prod release is worse than no report: it trains you to skim the line
that would matter when a job really does fail.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while releasing 8.0.25.01 to stage.
release-and-deploy.shprintedon a deploy that had succeeded.
Archive to Zenodowas skipped, not failed —site_deploy.yml:383gates it onneeds.deploy.result == 'success' && github.event.inputs.vcell_site == 'rel', so it skips on every stage and alpha deploy by design.The filter selected any conclusion that was neither
successnornull, andskippedis one of those. Now excluded, at both call sites (CI-full job summary and site_deploy job summary).A false alarm on every non-prod release is worse than no report — it trains you to skim the one line that would matter when a job really does fail.
🤖 Generated with Claude Code