fix(TerrainExtension): Handle pick events in TerrainExtension & draped layers#10037
Merged
felixpalmer merged 42 commits intomasterfrom Mar 4, 2026
Merged
fix(TerrainExtension): Handle pick events in TerrainExtension & draped layers#10037felixpalmer merged 42 commits intomasterfrom
felixpalmer merged 42 commits intomasterfrom
Conversation
chrisgervang
approved these changes
Feb 27, 2026
Collaborator
chrisgervang
left a comment
There was a problem hiding this comment.
Are there any caveats or downsides, or only net improvements from what you can tell?
The demo looks nice!
| deviceRect: viewport, | ||
| pickZ: false | ||
| pickZ: false, | ||
| clearColor: [0, 0, 0, terrainAlpha] |
Collaborator
There was a problem hiding this comment.
Most of these changes are in the picking pass and I'm assuming won't change draw pass renders. Is this change perceptible to the user?
Collaborator
Author
There was a problem hiding this comment.
No, except that picking works where it previously didn't
Collaborator
Author
From my testing none, just an improvement |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #9938 add support for
TerrainExtensionBackground
Getting 3D picking working with the
TerrainExtensionis a bit more involved as the shader flows are more complex. We need to handle:Screen.Recording.2026-02-25.at.16.39.48.mov
Change List
_getDepthLayerstoDeckPickerto explictly filter out correct layers when obtaining height