Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5855fe0b1e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| | `@deck.gl/layers` | `ScatterplotLayer` | ✅ | ✅ | | ||
| | `@deck.gl/layers` | `ColumnLayer` | ✅ | ❌ | | ||
| | `@deck.gl/layers` | `GridCellLayer` | ✅ | ❌ | | ||
| | `@deck.gl/layers` | `PathLayer` | ✅ | ✅ | |
There was a problem hiding this comment.
Mark PathLayer as unsupported on WebGPU
This row overstates the current porting status. Unlike the layers that are actually WebGPU-ready (IconLayer, LineLayer, PointCloudLayer, ScatterplotLayer), modules/layers/src/path-layer/path-layer.ts#getShaders still only supplies GLSL vs/fs shaders and there is no path-layer.wgsl.ts implementation in the tree. Because this page says the table is “source-based,” listing PathLayer as ✅ will mislead users into expecting a layer that has not been ported yet.
Useful? React with 👍 / 👎.
|
Nice! Excited about the WebGPU work going on here. |
Closes #
Background
Change List