Merged
Conversation
felixpalmer
requested review from
Pessimistress,
chrisgervang and
ibgreen
and removed request for
chrisgervang
Pessimistress
approved these changes
Mar 26, 2026
| setProps( | ||
| props: ControllerProps & | ||
| MapStateProps & { | ||
| rotationPivot?: 'center' | '2d' | '3d'; |
Collaborator
There was a problem hiding this comment.
should be default to 3d for this class?
| style={{backgroundColor: '#061714'}} | ||
| initialViewState={INITIAL_VIEW_STATE} | ||
| controller={{touchRotate: true, inertia: 250}} | ||
| controller={{type: TerrainController, touchRotate: true, inertia: 500}} |
Collaborator
There was a problem hiding this comment.
Exciting feature! This seems like one of the first times where a user will pick between controller classes - do our docs cover this interface in the Views guide?
I think it'd be useful to have an API reference for this too. We could make it very intuitive to understand with a few GIFs demoing each mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Currently the
MapControllerhas no concept of tracking the terrain. TherotationPivotmakes it possible to rotate the view around a fixed point in the scene. This PR introduces a new controller,TerrainController, which automatically tracks the terrain, smoothly updating thepositionz-component so that it is the same height as the terrain at the center of the viewportScreen.Recording.2026-03-25.at.20.26.02.mov
Change List
Tile3DLayer.filterSubLayerto perform culling to speed up picking performance (conservative approach, could likely do even better)TerrainController._pickTerrainCenterAltitudeobtains altitude at viewport center on interactionTerrainControllerviewport.position[2]updated smoothly on every frameTerrainController._rebaseViewportavoids jump on initial interaction