fix(mapbox): avoid crash when MapboxOverlay beforeId layer is removed#10425
Open
zbigg wants to merge 1 commit into
Open
fix(mapbox): avoid crash when MapboxOverlay beforeId layer is removed#10425zbigg wants to merge 1 commit into
zbigg wants to merge 1 commit into
Conversation
7 tasks
When a MapboxOverlay layer uses `beforeId` and the referenced map layer is
later removed (e.g. by map.setStyle() unloading it), resolveLayerGroups tried
to move the deck layer group before a layer that no longer exists. mapbox-gl's
moveLayer throws in that case ("Cannot move layer ... before non-existing
layer ..."), and since it splices the group out of the order before throwing,
the group is dropped entirely.
Skip the reorder when the beforeId target is not in the current layer order,
leaving the group in place until the reference reappears.
zbigg
force-pushed
the
zbigg/fix-mapboxoverlay-unknown-layer-crash
branch
from
154523f to
9ad4550
Compare
|
coverage: 83.138% (+0.003%) from 83.135% — zbigg/fix-mapboxoverlay-unknown-layer-crash into master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MapboxOverlay: Skip the attempt to reorder layer with
beforeIdwhen layer withbeforeIddoesn't exist in map instance.Background:
When a MapboxOverlay layer uses
beforeIdand the referenced map layer is later removed (e.g. bymap.setStyle()unloading it),resolveLayerGroupstried to move the deck layer group before a layer that no longer exists. mapbox-gl'smoveLayerthrows in that case ("Cannot move layer ... before non-existing layer ..."), and since it splices the group out of the order before throwing, the group is dropped entirely.Closes #10309
Change List
resolveLayerGroupsdoesn't attempt to move deck layer when it knowsbeforeIdlayer is missing