Display helpful error if h3 v4 is accidentally included#7283
Merged
felixpalmer merged 5 commits intomasterfrom Oct 17, 2022
Merged
Display helpful error if h3 v4 is accidentally included#7283felixpalmer merged 5 commits intomasterfrom
felixpalmer merged 5 commits intomasterfrom
Conversation
zbigg
approved these changes
Oct 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #7058 and #7177
If no version is explictly specified for the H3 library deck.gl, v4 is automatically included and leads to misleading errors. Many existing scripts out there include h3 without the version explictly set to v3.
Change List