RFC: Automatic and Explicit Highlighting#839
Merged
Conversation
ibgreen
approved these changes
Aug 10, 2017
| Ravi Akkenapally and Ib Green | ||
|
|
||
| August 9, 2017 | ||
|
|
Collaborator
There was a problem hiding this comment.
Add a link to this PR here, so that people know where to add comments.
|
|
||
| 3. **autoHighlight** {Boolean, default: false} : [**Proposed**] for now, this is a boolean value, indicating that deck.gl will automatically track the hovered over object. Note: This could be extended in future to specify ‘hover’ , ‘click’ etc events, for different types of tracking. **selectedObjectIndex** prop takes precedence when both **selectedObjectIndex**and **autoHighlight** are set to valid values. | ||
|
|
||
| 4. **highlightColor **{vec3: default: light-blue color [0, 0, 128]} : [**Proposed**] - This indicates which color should be used to display the selected object, if any. |
Collaborator
There was a problem hiding this comment.
My expectation was the highlight color was an RGBA value, and that the default would contain an alpha value (semi transparent).
|
|
||
| This table describes what these prop values should be to for above mentioned use cases: | ||
|
|
||
| <table> |
Collaborator
There was a problem hiding this comment.
Nit: This is OK but for tables in markdown we usually use markdown's vertical bar syntax, easier to edit.
|
|
||
| * Default color for highlighting | ||
|
|
||
| * A transparent light blue is proposed. Name a specific RGBA value? |
Collaborator
There was a problem hiding this comment.
Seems we already did, maybe remove this.
|
|
||
| **Considerations** | ||
|
|
||
| * How to calculate picking colors: |
Collaborator
There was a problem hiding this comment.
I think the proposed interface is not exposing picking colors, so maybe this comment is moot.
This was referenced Aug 15, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.