Merged
Conversation
ibgreen
approved these changes
Jul 22, 2024
|
|
||
| vec3 normal; | ||
| if (flatShading) { | ||
| if (simpleMesh.flatShading) { |
Collaborator
There was a problem hiding this comment.
Nit: is our object of attention called mesh in some files and simpleMesh in others? Possible to align? Or a good reason?
Collaborator
Author
There was a problem hiding this comment.
Well, the "good" reason is that we have SimpleMeshLayer in mesh-layers and MeshLayer which extends it in geo-layers. I'm not aware of the history of why we have two layers, @Pessimistress would it be a good idea to combine the two? At any rate, I'm not going to address this as part of the UBO work
donmccurdy
approved these changes
Jul 22, 2024
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #8997
Change List
MeshLayerTripsLayer