feat(core): Add Deck#getView() method #9948
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisgervang
commented
Jan 20, 2026
| const viewState = getViewState(map); | ||
| const {views} = deck.props; | ||
| const view = | ||
| (views && flatten(views).find((v: {id: string}) => v.id === MAPBOX_VIEW_ID)) || |
Collaborator
Author
There was a problem hiding this comment.
I thought the use of flatten was odd since I can't think of a case where you'd have nested arrays of views.. the type is
// view-manager.ts:18
export type ViewOrViews = View | View[] | null;
But, looks like ViewManager is likely just being defensive, or its an old pattern?
// view-manager.ts:268-269
private _setViews(views: View[]): void {
views = flatten(views, Boolean); // why are views flattened?
...
}
Either way, calling deck.getView() maintains the same behavior since view manager already normalized the list.
Add a public `getView(viewId)` method to the Deck class that returns a View by its id. This extracts the view lookup logic that was previously duplicated in places like MapboxOverlay's deck-utils. - Add `Deck#getView(viewId: string): View | undefined` - Update `getViewport` in deck-utils to use the new API - Add tests for single view and multiple views cases Closes #9709 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
chrisgervang
force-pushed
the
chrisgervang/viewport-from-map
branch
from
aecfd6a to
345dc2a
Compare
Open
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9709
Summary
Deck#getView(viewId)method that returns a View by its idgetViewportin@deck.gl/mapboxdeck-utils to use the new API instead of manually searching throughdeck.props.viewsThis extracts the view lookup logic that was previously duplicated, making it a proper part of the Deck public API.
Test plan
modules/coreandmodules/mapboxDeck#getView with single view,Deck#getView with multiple views)🤖 Generated with Claude Code
Note
Adds a public API to fetch a view by id and refactors mapbox integration to use it.
deck.getView(viewId)inDeckwith tests for single/multiple viewsmodules/mapbox/src/deck-utils.ts:getViewportnow usesdeck.getView(MAPBOX_VIEW_ID)instead of scanningdeck.props.views; narrows type when settingnearZMultiplierdocs/api-reference/core/deck.md): documentgetView, and add/clarifygetViews/getViewportssectionsWritten by Cursor Bugbot for commit 345dc2a. This will update automatically on new commits. Configure here.