Skip to content

fix: Add compilerOptions: {paths: {}} - #57

Merged
Pessimistress merged 1 commit into
masterfrom
felix/cjs-build-fix
Sep 3, 2026
Merged

fix: Add compilerOptions: {paths: {}}#57
Pessimistress merged 1 commit into
masterfrom
felix/cjs-build-fix

Conversation

@felixpalmer

@felixpalmer felixpalmer commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Testing the new deck build I've hit some issues with the built CJS packages (ESM seems fine)

Symptoms

  ┌──────────────────────────────┬────────┬──────────┬─────────┬───────────┐
  │           PACKAGE            │ BYTES  │ REQUIRES │ INLINED │ __VERSION__ │
  ├──────────────────────────────┼────────┼──────────┼─────────┼───────────┤
  │ @deck.gl/react@9.3.11        │ 20163  │ 4        │ 0       │ 0         │
  ├──────────────────────────────┼────────┼──────────┼─────────┼───────────┤
  │ @deck.gl/react@9.4.0-beta.3  │ 535294 │ 0        │ 102     │ 1         │
  ├──────────────────────────────┼────────┼──────────┼─────────┼───────────┤
  │ @luma.gl/engine@9.3.0        │ 201647 │ 14       │ 0       │ 0         │
  ├──────────────────────────────┼────────┼──────────┼─────────┼───────────┤
  │ @luma.gl/engine@9.4.0-beta.6 │ 596978 │ 0        │ 36      │ 1         │
  ├──────────────────────────────┼────────┼──────────┼─────────┼───────────┤
  │ @luma.gl/gltf@9.3.0          │ 92547  │ 3        │ 0       │ 0         │
  ├──────────────────────────────┼────────┼──────────┼─────────┼───────────┤
  │ @luma.gl/gltf@9.4.0-beta.6   │ 771589 │ 0        │ 31      │ 0         │
  └──────────────────────────────┴────────┴──────────┴─────────┴───────────┘

In moving from 9.3 to 9.4 the index.cjs packages sizes grow substantially, the number of required (REQUIRES = require("<sibling>")) modules drops to 0, instead being inlined and typeof __VERSION__ appears in the final build.

Cause

Changes in the paths in package.json from "@deck.gl/arcgis": ["modules/arcgis/src"] to "@deck.gl/arcgis": ["./modules/arcgis/src"] in github.com/visgl/deck.gl/pull/10531/ or visgl/luma.gl#2811

Changes

  • Empty paths in tsconfigRaw
  • Test

@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 33740522780

Coverage increased (+0.09%) to 54.693%

Details

  • Coverage increased (+0.09%) from the base build.
  • Patch coverage: 1 uncovered change across 1 file (0 of 1 lines covered, 0.0%).
  • No coverage regressions found.

Uncovered Changes

File Changed Covered %
modules/dev-tools/src/configuration/get-esbuild-config.ts 1 0 0.0%

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 618
Covered Lines: 330
Line Coverage: 53.4%
Relevant Branches: 490
Covered Branches: 276
Branch Coverage: 56.33%
Branches in Coverage %: Yes
Coverage Strength: 4.56 hits per line

💛 - Coveralls

@Pessimistress
Pessimistress merged commit 4e2fa9b into master Sep 3, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants