Skip to content

feat: Sort table values properly#873

Merged
bprusinowski merged 4 commits intomainfrom
feat/sort-table-values-properly
Nov 21, 2022
Merged

feat: Sort table values properly#873
bprusinowski merged 4 commits intomainfrom
feat/sort-table-values-properly

Conversation

@bprusinowski
Copy link
Copy Markdown
Member

@bprusinowski bprusinowski commented Nov 18, 2022

Closes #871.

position -> label?

How to test

  1. Go to /en/browse?dataset=https%3A%2F%2Fenvironment.ld.admin.ch%2Ffoen%2Fubd003001_colors%2F2&dataSource=Int.
  2. Create a table chart.
  3. Look at the values inside the table and see that they are sorted left to right, according to position -> identifier -> label.
  4. Check that it's still possible to sort individual columns and that they still take the above logic into account. Best visible with Status column.

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Nov 18, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
visualization-tool ✅ Ready (Inspect) Visit Preview Nov 21, 2022 at 3:28PM (UTC)

@bprusinowski bprusinowski merged commit 86a7e68 into main Nov 21, 2022
@bprusinowski bprusinowski deleted the feat/sort-table-values-properly branch November 21, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sort Ordinal Dimension by schema:position in table

2 participants