Skip to content

Add simple test to image before uploading#1

Merged
pheki merged 2 commits into
vita-rust:mainfrom
pheki:test-image
Jan 16, 2024
Merged

Add simple test to image before uploading#1
pheki merged 2 commits into
vita-rust:mainfrom
pheki:test-image

Conversation

@pheki

@pheki pheki commented Jan 16, 2024

Copy link
Copy Markdown
Member

This would help us:

  • Not push images with broken compiler / std versions
  • Realize sooner when the compiler / std breaks (although for this one we also probably want to build all examples)

@nikarh

nikarh commented Jan 16, 2024

Copy link
Copy Markdown
Member

Makes a lot of sense, thanks!
Approved, merge it when you feel like it :)

@nikarh

nikarh commented Jan 16, 2024

Copy link
Copy Markdown
Member

Also, if you know the last good nightly, please rerun the workflow (there's a manual trigger where you can enter the version to use), so that image:latest is the working one :)

@pheki
pheki merged commit 5e57493 into vita-rust:main Jan 16, 2024
@pheki

pheki commented Jan 16, 2024

Copy link
Copy Markdown
Member Author

if you know the last good nightly, please rerun the workflow, so that image:latest is the working one

Oh right, done! For reference it's nightly-2024-01-04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants