Skip to content

fix(ci): build darwin-amd64 binary on macos-15-intel runner#644

Merged
vitali87 merged 1 commit into
mainfrom
fix/darwin-amd64-runner
Jul 7, 2026
Merged

fix(ci): build darwin-amd64 binary on macos-15-intel runner#644
vitali87 merged 1 commit into
mainfrom
fix/darwin-amd64-runner

Conversation

@vitali87

@vitali87 vitali87 commented Jul 7, 2026

Copy link
Copy Markdown
Owner

Problem

The v0.0.246 release shipped only three binaries despite a four-platform matrix. The darwin-amd64 matrix entry runs on macos-latest, which GitHub now maps to macos-15-arm64. The binary name is derived from platform.machine() at runtime, so that job silently built a second code-graph-rag-darwin-arm64 that overwrote the real one on release upload, and Intel Mac users got no binary at all.

Fix

  • Pin the darwin-amd64 matrix entry to macos-15-intel, GitHub's free x64 macOS runner.
  • Smoke-test the exact expected filename (code-graph-rag-<platform>-<arch>) instead of a glob, so any future runner-arch/matrix mismatch fails the job loudly instead of silently mislabeling a release asset.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the version of the code-graph-rag package in uv.lock from 0.0.245 to 0.0.246. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@greptile-apps

greptile-apps Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR fixes the release binary workflow for Darwin amd64 builds. The main changes are:

  • Pins the darwin-amd64 matrix entry to the macos-15-intel runner.
  • Smoke-tests the exact expected binary filename for each matrix entry.
  • Updates the locked editable package version to 0.0.246.

Confidence Score: 5/5

Safe to merge with minimal risk.

The changes are narrowly scoped to CI runner selection and artifact filename validation. No functional or security issues were identified.

No files require special attention.

T-Rex T-Rex Logs

What T-Rex did

  • T-Rex ran the requested general-contract-validation-proof, but local artifact references were not uploaded.

T-Rex Ran code and verified through T-Rex

Important Files Changed

Filename Overview
.github/workflows/build-binaries.yml Pins the Darwin amd64 build to the Intel macOS runner and validates the exact matrix-derived binary filename before upload.
uv.lock Updates the editable package version from 0.0.245 to 0.0.246.

Reviews (1): Last reviewed commit: "fix(ci): build darwin-amd64 on macos-15-..." | Re-trigger Greptile

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@vitali87
vitali87 merged commit 33ce0a2 into main Jul 7, 2026
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants