fix(ci): declare unrun as devDependency where tsdown uses it#368
Merged
Conversation
`tsdown --config-loader=unrun` relies on an optional peer of tsdown that was previously satisfied transitively via `@vitejs/devtools@0.1.24`. The latest deps update replaced that resolution and dropped unrun from the lockfile, breaking the build.
commit: |
splitpanes 4.1.2 tightened the resize payload type so `prevPane` is now possibly undefined. Accept the full payload in the handler and narrow before reading `prevPane.size`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Restore green CI.
packages/coreand three example plugins build withtsdown --config-loader=unrun, butunrunis only an optional peer dep oftsdown@0.22.0and was previously satisfied transitively via the npm-published@vitejs/devtools@0.1.24. The recentchore: update deps(f444ccd) replaced that resolution with@vitejs/devtools@0.2.0, which no longer pullsunrunin — the optional peer dropped out of the lockfile and the next clean install on CI failed every build job withFailed to import module "unrun". Declaringunrunexplicitly in the build catalog and in each consuming package makes the dependency resolution self-contained instead of relying on a transitive accident.Linked Issues
Fixes the failing run https://github.com/vitejs/devtools/actions/runs/26556373838.
Additional context
The lockfile shrinks substantially because the stale
@vitejs/devtools@0.2.0transitive resolution (and its@pnpm/*graph) is no longer needed onceunrunis a direct dep.This PR was created with the help of an agent.