fix(rsc): avoid rewriting filtered exports in transformWrapExport - #1387
Merged
Conversation
Select exports before mutating their declarations, preserve skipped specifiers, and validate selected uninitialized bindings. Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
hi-ogawa
changed the title
transformWrapExport
hi-ogawa
marked this pull request as ready for review
August 4, 2026 08:09
Co-authored-by: OpenCode <noreply@opencode.ai>
This was referenced Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
transformModuleExportWrapand deprecatetransformWrapExport(take 2) #1381I realized
transformModuleExportWrap(introduced in #1381) and existingtransformWrapExportshare almost same logic with minor twist as explained in the pr description #1381.The apparent divergence turns out to be something
transformWrapExportcan address on its own, so this PR basically aligns the structure fromtransformModuleExportWrap, which has a cleaner code path as it's built from scratch.The concrete behavioral aspect of the alignment is to skip transform entirely when all exports are filtered out.