Skip to content

Conversation

@vitess-bot
Copy link
Contributor

@vitess-bot vitess-bot bot commented May 9, 2025

Description

This is a backport of #18254

@vitess-bot vitess-bot bot requested a review from harshit-gangal as a code owner May 9, 2025 08:06
@vitess-bot vitess-bot bot added Backport This is a backport Component: Evalengine changes to the evaluation engine labels May 9, 2025
@vitess-bot vitess-bot bot requested a review from systay as a code owner May 9, 2025 08:06
@vitess-bot vitess-bot bot added the Type: Bug label May 9, 2025
@vitess-bot vitess-bot bot requested review from dbussink and vmg May 9, 2025 08:06
@vitess-bot
Copy link
Contributor Author

vitess-bot bot commented May 9, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@github-actions github-actions bot added this to the v20.0.8 milestone May 9, 2025
@codecov
Copy link

codecov bot commented May 9, 2025

Codecov Report

Attention: Patch coverage is 84.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 66.41%. Comparing base (4bd42e8) to head (c88f32c).
Report is 1 commits behind head on release-20.0.

Files with missing lines Patch % Lines
go/vt/vtgate/evalengine/fn_compare.go 83.67% 8 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-20.0   #18256      +/-   ##
================================================
+ Coverage         66.40%   66.41%   +0.01%     
================================================
  Files              1543     1543              
  Lines            244895   244938      +43     
================================================
+ Hits             162624   162683      +59     
+ Misses            82271    82255      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dbussink dbussink merged commit a813f02 into release-20.0 May 9, 2025
190 of 193 checks passed
@dbussink dbussink deleted the backport-18254-to-release-20.0 branch May 9, 2025 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport This is a backport Component: Evalengine changes to the evaluation engine Type: Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants