fix: use explicit ?os= parameter in download URLs #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When users copy the curl/wget command, the user-agent is just 'curl/XXX' or 'wget/XXX' which doesn't identify the OS. This causes the server to fall back to serving its own binary instead of the correct one. Fix by including explicit ?os= parameter in all download URLs: - Linux: https://get.shellshare.net/?os=linux - macOS: https://get.shellshare.net/?os=mac (Intel, works on ARM via Rosetta) - Windows: https://get.shellshare.net/?os=windows Closes #98
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When users copy the curl/wget command from the website and run it, the user-agent is just
curl/XXXorwget/XXXwhich doesn't identify the operating system. This causes the server to fail OS detection and fall back to serving its own binary instead of the correct one for the user's platform.Fixes #98
Solution
Include explicit
?os=parameter in all download URLs:https://get.shellshare.net/?os=linuxhttps://get.shellshare.net/?os=mac(Intel binary, works on Apple Silicon via Rosetta 2)https://get.shellshare.net/?os=windowsChanges
Updated all download URLs in
templates/index.html: