Document two CSS limits of Yahoo Mail - #6309
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (8)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughThe changes document Yahoo Mail and Outlook.com CSS limitations. Responsive email stories and references now add percentage width fallbacks before ChangesEmail client compatibility
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change documents email-client CSS limitations and adds percentage fallbacks before existing calc() declarations in example layouts. No concrete merge-blocking behavior or compatibility risk remains identified. 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
Full details: Title checkExplanation The title clearly identifies the main documentation change: two Yahoo Mail CSS limitations. It is concise and related to the changeset, although it does not mention the related Outlook.com guidance or fallback implementation. Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files. (6 skipped: 6 unsupported.) Full details: Requires Human ReviewExplanation The PR changes eight files. All documentation and skill changes are excluded by the check. The two changed TSX story files add 16 hand-written source lines, which is below 300. No prohibited authentication, authorization, migration, CI, secret, or credential changes appear. No tests are deleted, and no exported declarations change. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
6581860 to
8bcc8e5
Compare
db60bd3 to
f1fcc77
Compare
Percentage columns would have removed the `calc()` altogether, but they let the narrow column shrink below `bodyWidth`, so the layout would change in every client instead of only in the ones with the defect.
f1fcc77 to
af302d4
Compare
|
@coderabbitai review |
✅ Action performedReview finished.
|
Percentage columns would have removed the
calc()altogether, but they let the narrow column shrink belowbodyWidth, so the layout would change in every client instead of only in the ones with the defect.Task: https://vivid-planet.atlassian.net/browse/PHSB2C-13730