net: preserve socket errors across syscall boundaries - #460
Open
xuchang-vivo wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
build_prs |
|
Job is started, see https://github.com/vivoblueos/kernel/actions/runs/32947049817. |
|
✅ All jobs completed successfully, see https://github.com/vivoblueos/kernel/actions/runs/32947049817. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConnectionErrorandSocketErrorvariants to specific negative POSIX errno values.-1.code::ERROR.Motivation
The BlueOS network stack already distinguishes conditions such as timeout, would-block, invalid file descriptor, queue exhaustion, and address conflicts. The socket syscall and VFS boundaries previously collapsed these failures to a generic
-1, losing the original reason before it reached libc.For example, a timeout should leave the kernel as
-ETIMEDOUT, allowing the libc wrapper to return-1witherrno = ETIMEDOUT. Returning a bare-1from the kernel instead makes the libc layer interpret the error number as1or observe stale errno.This complements vivoblueos/librs#38, which converts negative kernel errno results to the POSIX libc
-1pluserrnoconvention.This PR only preserves reported errors. It does not implement socket timeout enforcement or change network operation behavior.
POSIX references
errnosend()recv()Testing
rustfmt --check kernel/src/net/connection_err.rs kernel/src/net/socket/socket_err.rs kernel/src/net/syscalls.rs kernel/src/vfs/sockfs.rsgit diff --check