♻️ Split uploader boundaries#262
Merged
Robdel12 merged 1 commit intoMay 18, 2026
Merged
Conversation
Robdel12
force-pushed
the
rd/cli-audit-server-events
branch
from
4fd0a8a to
9074055
Compare
Base automatically changed from
rd/cli-audit-server-events
to
rd/cli-audit-remaining-base
May 18, 2026 19:30
Move the uploader implementation and its tests into a focused boundary-cleanup branch.
Robdel12
force-pushed
the
rd/cli-audit-services-uploader
branch
from
4f542ac to
631f78f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Uploader behavior is a production boundary: it scans files, builds metadata, deduplicates screenshots, uploads batches, waits for builds, and reports progress. The old service-level uploader wrapper made that path harder to review because the real uploader logic and compatibility shim lived in different places.
This PR narrows the uploader cleanup to that boundary. It removes the stale service wrapper and makes the uploader module itself the honest place to review upload behavior and tests.
What Changed
src/uploaderboundary.src/services/uploader.jscompatibility module and matching obsolete service test.Verification
npm run buildnode --test tests/uploader/core.test.js tests/uploader/index.test.js tests/uploader/operations.test.jsStack
7/10 in the CLI audit stack.
Base:
rd/cli-audit-server-eventsHead:
rd/cli-audit-services-uploader