♻️ Finish CLI audit cleanup stack#265
Merged
Merged
Conversation
Why: merge server event/dashboard cleanup into the remaining audit integration base so the final PR can absorb the whole tail of the stack together.\n\nWhat changed:\n- Event/dashboard route wiring and adjacent smoke coverage.\n- Cleanup of older server event patterns now that baseline routes are already merged.\n\nVerification:\n- This slice will be verified through the final remaining-stack PR into main.
Why: merge the uploader boundary cleanup into the remaining audit integration base so the final PR can verify the full tail together.\n\nWhat changed:\n- Moved uploader implementation into the uploader module boundary.\n- Updated public/command/SDK imports to the new uploader boundary.\n- Replaced old service tests with uploader boundary tests.\n\nVerification:\n- node --test tests/uploader/index.test.js tests/commands/upload.test.js tests/commands/run.test.js tests/sdk/index.test.js\n- Final verification will happen on the last PR back to main.
Why: merge TDD/status/runtime plumbing into the remaining audit integration base so the final PR can verify the full runtime cleanup together.\n\nWhat changed:\n- Status, doctor, preview, TDD daemon, run, and supporting runtime service cleanup.\n- Removed obsolete service-manager and region-service paths.\n- Added/updated focused command and TDD service tests.\n\nVerification:\n- npm run lint\n- Final verification will happen on the last PR back to main.
Robdel12
force-pushed
the
rd/cli-audit-storybook-client
branch
from
3bc3129 to
b205d53
Compare
Why: merge Storybook/client wiring into the remaining audit integration base so the final static-site PR can verify all remaining client package changes together.\n\nWhat changed:\n- Storybook integration and shared plugin loading updates.\n- Adjacent client package wiring needed before the final static-site slice.\n\nVerification:\n- Final verification will happen on the last PR back to main.
Base automatically changed from
rd/cli-audit-storybook-client
to
rd/cli-audit-remaining-base
May 18, 2026 19:35
Robdel12
force-pushed
the
rd/cli-audit-static-site-client
branch
from
78c3057 to
4054753
Compare
Robdel12
changed the title
Why: make the final static-site slice carry the remaining CLI audit stack into main after the dependent PRs were merged into the integration base. This keeps the smaller PR history intact while giving GitHub one final branch to verify against trunk.
Robdel12
force-pushed
the
rd/cli-audit-static-site-client
branch
from
4054753 to
5d4ecc2
Compare
Vizzly - Visual Test Results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This PR is the final landing PR for the remaining CLI audit stack.
The first half of the stack is already on
main; this branch carries the restforward without turning the work into one giant, context-free squash. The shape
is intentional: keep each review unit as a real PR, merge the dependent pieces
into one integration base, and only babysit this final branch back into
main.That gives us the outcome we wanted from the audit without spending a ton of
time manually re-validating every leaf branch against trunk. The changes here
remove old compatibility paths, make command/server/client boundaries easier to
reason about, and add outcome-focused coverage around the places that were most
likely to regress.
What changed
asset validation, config, dashboard, cloud proxy, health, and event behavior.
services/uploadercompatibility layer.daemon coverage for the user-visible flows.
server lifecycle, tab pools, plugin entrypoints, and task processing.
server lifecycle, tab pools, plugin entrypoints, task processing, and sitemap
parsing.
next to the tests that prove XML parsing still behaves correctly.
carrying real behavior.
Verification
npm run lintnpm run buildStack context
Final PR for the remaining stack:
Base:
mainHead:
rd/cli-audit-static-site-client