♻️ Split Storybook client wiring#264
Merged
Robdel12 merged 1 commit intoMay 18, 2026
Merged
Conversation
Robdel12
force-pushed
the
rd/cli-audit-tdd-status
branch
from
3f22a2a to
e96043b
Compare
Base automatically changed from
rd/cli-audit-tdd-status
to
rd/cli-audit-remaining-base
May 18, 2026 19:34
Group the Storybook integration, shared plugin loading, and adjacent client package refs into one review slice.
Robdel12
force-pushed
the
rd/cli-audit-storybook-client
branch
from
3bc3129 to
b205d53
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Storybook client is one of the main package integrations for the CLI, and it has its own server, navigation, pooling, screenshot, and plugin-loading behavior. It needs to be reviewable independently from core CLI/server changes because package consumers should be able to validate the Storybook integration without reading the entire CLI audit.
This PR isolates the Storybook package cleanup plus the closely related plugin-loader and Ember/Vitest compatibility touchpoints that support client package behavior.
What Changed
Verification
npm run buildnode --test clients/storybook/tests/concurrency.test.js clients/storybook/tests/crawler.test.js clients/storybook/tests/navigation.test.js clients/storybook/tests/server.test.js clients/storybook/tests/tasks.test.js tests/plugin-loader.test.jsStack
9/10 in the CLI audit stack.
Base:
rd/cli-audit-tdd-statusHead:
rd/cli-audit-storybook-client