🐛 Keep user test suites running through Vizzly network errors#312
Merged
Conversation
Fail open when build setup or status polling hits an availability error so Vizzly infrastructure cannot prevent the user's tests from running. Preserve actionable client errors and authoritative test exit codes.
Robdel12
changed the title
Robdel12
changed the title
Vizzly - Visual Test ResultsCLI Reporter - Waiting for buildNo builds received yet for this pull request. CLI TUI - 5 changes need review
Meaningful diffs needing review (5)vizzly-run-help · 1202×722 · 0.1% diff vizzly-doctor · 1202×578 · 0.2% diff vizzly-tdd-help · 1202×578 · 0.2% diff vizzly-help · 1202×1430 · 0.0% diff vizzly-invalid-command · 1202×578 · 0.2% diff
|
Robdel12
changed the title
Disable Vizzly for every setup or network failure while preserving the user's test command exit code as the source of truth.
Robdel12
marked this pull request as ready for review
July 20, 2026 18:07
Use the completed run result as the single post-test guard and remove polling context and redundant status cases that no longer affect behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Vizzly observes a user test suite; it should never become the reason that suite fails. Build setup previously ran before the child command, so API, Cloudflare, authentication, malformed-response, or other SDK errors could stop healthy tests from running or change their result.
Approach
Make the user test command the source of truth. Any Vizzly setup error disables visual testing for that invocation and runs the child command normally, while errors after the child passes are logged and ignored regardless of status code. Real child command failures and intentional visual comparison failures keep their existing behavior.
The screenshot client already treats in-test transport and upload failures this way, so this applies the same fail-open principle to build creation, local server setup, screenshot accounting, and wait-mode polling.
Evidence
The regression coverage follows real CLI workflows for a rejected 401 response and a provider-style 503 HTML response. Focused tests cover malformed build data, local setup failures, server startup failures, post-test SDK failures, and wait-mode polling errors. All 2,294 runnable tests pass with zero failures, and Biome reports a clean changed-file check.