Первый ПР для первого задания#1
Open
vladsharipov wants to merge 7 commits into
Open
Conversation
…ования стоимости.
…в список и суммирования стоимости. Добавил вывод результата и обработку ошибок.
faritowich
reviewed
Dec 1, 2022
| System.out.println("Упс! Для верного расчёта количество человек должно быть больше 1. Попробуйте ещё раз:"); | ||
| } | ||
| catch (NumberFormatException exception) { | ||
| System.out.println("Нужно ввести целое число больше 1. Попробуйте ещё раз:"); |
There was a problem hiding this comment.
Имеет смысл выносить такие большие логические фрагменты в отдельные методы и вызывать их там, где необходимо. Это делает программу более удобочитаемой, когда разнородная логика не смешивается в один сплошной код.
| } | ||
| } | ||
| goodList.append(name + "\n"); | ||
| priceSum = priceSum + price; |
There was a problem hiding this comment.
Также можно использовать сокращенную конструкцию priceSum += price;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Мои коммиты с 23.11. Сам вносил изменения только в классы Main и Goods. Спасибо за вашу работу.