checker: fix wrapped fn aliases in multiple returns - #27977
Merged
Conversation
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #27976.
What changed
Root cause
The checker only applied wrapped function-alias compatibility when the complete method return type was a function. A
MultiReturnsymbol stopped that comparison before it reached the optional function component, so identical signatures were rejected.Impact
Concrete methods whose multiple-return signatures exactly match an interface now satisfy that interface when a component is an optional function type alias. Existing incompatible wrapped-alias cases remain rejected.
Checks
VFLAGS='-gc none' ./vnew -gc none -silent vlib/v/compiler_errors_test.v(1604 passed, 1 skipped)VFLAGS='-old-compiler -gc none' ./vnew -old-compiler -gc none -silent test vlib/v/tests/interfaces/(101 passed)VFLAGS='-old-compiler -gc none' ./vnew -old-compiler -gc none -silent test vlib/v/ast/(5 passed)VFLAGS='-old-compiler -gc none' ./vnew -old-compiler -gc none -silent test vlib/v/checker/(3 passed)A full
vlib/v/run was also started, but the isolated worktree does not contain the ignored bundledthirdparty/tccGC runtime, so GC-specific tests failed on missinglibgc.dylibbefore the run completed.