-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
fix to read vroot from environent variable #559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-Authored-By: Nathan Kramer <nathan.kramer@trineo.co.nz>
|
Thanks, but I don't like asking the user to set the path, when V already knows the path. There must be a way to permanently set the path programmatically. |
|
I'm working on a solution without env vars: Everything will be stored in ~/.vmodules, including builtin. |
|
Hey So we spent lots of time discussing how to do this. And we found a way to avoid env variables. I just pushed a temporary solution to this particular issue, so I'm going to close this. Please submit |
|
@medvednikov BTW, do you have a plan to publish install script to the vlang.io? in this way, we can even prompt vroot for a user with a default value. |
|
@musou1500 This is not secure, we can provide auto-compiler archives from CI, we can simplify the installation procedure from source codes, we can add auto-update feature. It'll be enough. |
|
@whoizit |
|
because the server can be hacked at any time and malicious code can be added to the script |
|
install.sh should be placed in repository and we can make short link on it |
|
I see...if the server is cracked by an attacker, the attacker will be able to edit the website. |
|
No, it's different. github servers have professional admins. And if they get hacked, it will be their problem for reputation. Also git have a history of changes and it possible we can see what is changes and who did it. |
is it means that website(vlang.io) is hosted by GitHub Pages? |
|
no |
|
I see... anyway, I understand somehow about the security risk. thanks a lot. |
|
we can make copy-paste snippet like this: |
|
it would be nice. I'll consider creating a separate issue about it. |
currently,
vrootis determine from working directory if default path is not exists.it causes that std libraries can not refer
thirdpartydirectories.This PR fix it by use environent variable.
to operate with environemtn variables, I also added some functions to
osmodule.to merge thie PR, need to fix
v.ctoo.