Skip to content

Disable Logs Requests should Disable Logging of requests. - #1779

Merged
Yard1 merged 1 commit into
vllm-project:mainfrom
MichaelMcCulloch:main
Nov 30, 2023
Merged

Disable Logs Requests should Disable Logging of requests.#1779
Yard1 merged 1 commit into
vllm-project:mainfrom
MichaelMcCulloch:main

Conversation

@MichaelMcCulloch

@MichaelMcCulloch MichaelMcCulloch commented Nov 24, 2023

Copy link
Copy Markdown
Contributor
  • 1. Make sure your code has been rebased on top of the latest commit on the main branch.
  • 2. Ensure code is properly formatted by running format.sh.
  • 3. Include a detailed description of the changes in the pull request. Explain why you made the changes you did. If your pull request fixes an open issue, please include a reference to it in the description. Delete the hard coded logging within vllm.entrypoints.openai.api_server. The engine still produces logs.

I'm unclear on why the openai api has the privileged position of ignoring the --disable-log-requests flag.

@Yard1
Yard1 merged commit c782195 into vllm-project:main Nov 30, 2023
xjpang pushed a commit to xjpang/vllm that referenced this pull request Dec 4, 2023
@MichaelMcCulloch Michael McCulloch jimpang
Disable Logs Requests should Disable Logging of requests. (vllm-proje…
ab70097 
…ct#1779)

Co-authored-by: Michael McCulloch <mjm.gitlab@fastmail.com>
@slin1237 slin1237 mentioned this pull request Dec 5, 2023
Closed
hongxiayang pushed a commit to hongxiayang/vllm that referenced this pull request Feb 13, 2024
@MichaelMcCulloch Michael McCulloch
Disable Logs Requests should Disable Logging of requests. (vllm-proje…
86651cb 
…ct#1779)

Co-authored-by: Michael McCulloch <mjm.gitlab@fastmail.com>
jinyouzhi added a commit to jinyouzhi/vllm that referenced this pull request Sep 11, 2025
@jinyouzhi @CSWYF3634076
@vasqu @DarkLight1337
Porting ERNIE 4.5 and ERNIE 4.5 MoE model support (vllm-project#1779)
e502a28 
Enable ERNIE 4.5 series text generation models including Dense and MoE. 

This PR contains:
- cherry-pick vllm-project#20220
- bugfix vllm-project#21735 (name mistake)

then validate on

- [ERNIE-4.5-0.3B-PT](https://huggingface.co/baidu/ERNIE-4.5-0.3B-PT)
-
[ERNIE-4.5-21B-A3B-PT](https://huggingface.co/baidu/ERNIE-4.5-21B-A3B-PT)

@Wei-Lin-Intel

---------

Signed-off-by: wangyafeng <wangyafeng@baidu.com>
Signed-off-by: vasqu <antonprogamer@gmail.com>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Co-authored-by: CSWYF3634076 <58356743+CSWYF3634076@users.noreply.github.com>
Co-authored-by: Anton Vlasjuk <73884904+vasqu@users.noreply.github.com>
Co-authored-by: DarkLight1337 <tlleungac@connect.ust.hk>
jinyouzhi added a commit to jinyouzhi/vllm that referenced this pull request Sep 12, 2025
@jinyouzhi @CSWYF3634076
@vasqu @DarkLight1337 @czhu15
Porting ERNIE 4.5 and ERNIE 4.5 MoE model support (vllm-project#1779)
c3d983f 
Enable ERNIE 4.5 series text generation models including Dense and MoE. 

This PR contains:
- cherry-pick vllm-project#20220
- bugfix vllm-project#21735 (name mistake)

then validate on

- [ERNIE-4.5-0.3B-PT](https://huggingface.co/baidu/ERNIE-4.5-0.3B-PT)
-
[ERNIE-4.5-21B-A3B-PT](https://huggingface.co/baidu/ERNIE-4.5-21B-A3B-PT)

@Wei-Lin-Intel

---------

Signed-off-by: wangyafeng <wangyafeng@baidu.com>
Signed-off-by: vasqu <antonprogamer@gmail.com>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Co-authored-by: CSWYF3634076 <58356743+CSWYF3634076@users.noreply.github.com>
Co-authored-by: Anton Vlasjuk <73884904+vasqu@users.noreply.github.com>
Co-authored-by: DarkLight1337 <tlleungac@connect.ust.hk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Yard1 Yard1 Yard1 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MichaelMcCulloch @Yard1