[Model][Qwen3VL] Slighly speedup fast_pos_embed_interpolate
#28434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lukas Geiger <lukas.geiger94@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a minor but effective optimization in the fast_pos_embed_interpolate function by replacing a standard multiplication with an in-place multiplication. This change correctly reduces memory overhead by avoiding the creation of an intermediate tensor, which, as noted in the description, provides a nice performance improvement. The change is safe as the modified tensor is not used elsewhere. This is a good, clean optimization.
ywang96
approved these changes
Nov 11, 2025
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Nov 13, 2025
…roject#28434) Signed-off-by: Lukas Geiger <lukas.geiger94@gmail.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This slightly reduces the overhead of
fast_pos_embed_interpolateby using an in-place multiplication. Followup to #26647In a simple benchmark this speedups the function by ~20% for bfloat16 and ~30% for float32. Nothing major, but it's still a nice win.