fix: UTF-8 console output on Windows (Issue #201) - #216
Merged
Conversation
Add setupConsoleOutput() calling SetConsoleOutputCP(65001) and SetConsoleMode with ENABLE_VIRTUAL_TERMINAL_PROCESSING on Windows startup. Compile-time gated via builtin.os.tag. No-op on non-Windows. Closes #201
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements
SetConsoleOutputCP(65001)andENABLE_VIRTUAL_TERMINAL_PROCESSINGon Windows startup so--tablebox-drawing characters render correctly in default cmd.exe.Changes
SetConsoleOutputCP,GetStdHandle,GetConsoleMode,SetConsoleModesetupConsoleOutput()function (compile-time gated on Windows)setupConsoleOutput()at startup inmain()before any I/OImplementation Details
extern "kernel32"withcallconv(.winapi)— no new dependencies@import("builtin").os.tag == .windows— zero overhead on non-WindowsSTD_OUTPUT_HANDLE = -11bug (u32 can't hold -11) →@bitCast(@as(i32, -11))std.os.windowstypes directly (removed intermediatewindowsimport)// 0xFFFFFFF5for readabilityINVALID_HANDLE_VALUEcheck — guards against redirected stdout whereGetStdHandlereturns invalid handleTesting
zig build(native) succeedszig build -Dtarget=x86_64-windows-gnu -Dbundle-sqlite=truesucceedszig build -Dtarget=x86-windows-gnu -Dbundle-sqlite=truesucceedszig build -Dtarget=aarch64-windows-gnu -Dbundle-sqlite=truefails — pre-existing carquet/arocc issue unrelated to this changeOracle Reviews
All 3 phases reviewed and approved:
Closes #201