This repository was archived by the owner on Sep 1, 2026. It is now read-only.
quickstart-vdk: Run vdk-heartbeat before release - #665
Merged
YanaZhivkova merged 3 commits intoFeb 16, 2022
Merged
Conversation
YanaZhivkova
force-pushed
the
person/yzhivkova/Run_vdk-heartbeat_before_quickstart-vdk_release
branch
4 times, most recently
from
January 5, 2022 17:19
52f70d8 to
3135481
Compare
ivakoleva
reviewed
Jan 6, 2022
YanaZhivkova
force-pushed
the
person/yzhivkova/Run_vdk-heartbeat_before_quickstart-vdk_release
branch
3 times, most recently
from
January 7, 2022 16:44
b230d83 to
21eac82
Compare
doks5
reviewed
Feb 9, 2022
YanaZhivkova
force-pushed
the
person/yzhivkova/Run_vdk-heartbeat_before_quickstart-vdk_release
branch
9 times, most recently
from
February 14, 2022 08:56
ac0bd02 to
54fd7f2
Compare
antoniivanov
approved these changes
Feb 15, 2022
Currently, plugin versions are not fixed in quickstart-vdk and when we upgrade, we can accidentally break it. That is why it is necessary to run some verification before we release it. Run vdk-heartbeat before releasing quickstart-vdk (during pre-release stage). Create release-candidate package and image of quickstart-vdk and run vdk-heartbeat with them during pre-release stage of each quickstart-vdk dependency CI/CD. Testing Done: test CI/CD pipeline. Also, check that the release-candidate image of quickstart-vdk is run on the vdk-heartbeat job k8s pod. Signed-off-by: Yana Zhivkova <yzhivkova@vmware.com>
Every quickstart-vdk dependency (including vdk-core) is tested with pre-release quickstart-vdk CI/CD jobs. See test_quickstart_vdk_locations in quickstart-vdk CI/CD job definitions. Remove old and unnecessary vdk-core release acceptance tests. Testing Done: CI/CD pipeline Signed-off-by: Yana Zhivkova <yzhivkova@vmware.com>
YanaZhivkova
force-pushed
the
person/yzhivkova/Run_vdk-heartbeat_before_quickstart-vdk_release
branch
from
February 16, 2022 07:14
cae7493 to
cb44a81
Compare
Add comment about locations of dependencies of quickstart-vdk which trigger CI/CD jobs when changed. Testing Done: CI/CD pipeline Signed-off-by: Yana Zhivkova <yzhivkova@vmware.com>
YanaZhivkova
deleted the
person/yzhivkova/Run_vdk-heartbeat_before_quickstart-vdk_release
branch
February 16, 2022 07:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, plugin versions are not fixed in quickstart-vdk
and when we upgrade, we can accidentally break it. That is why it is
necessary to run some verification before we release it.
Run vdk-heartbeat before releasing quickstart-vdk (during pre-release stage).
Create release-candidate package and image of quickstart-vdk and
run vdk-heartbeat with them during pre-release stage of
each quickstart-vdk dependency CI/CD.
Testing Done: CI/CD pipeline - https://gitlab.com/vmware-analytics/versatile-data-kit/-/pipelines/470250661.
Also, check that the release-candidate image of quickstart-vdk is run on the vdk-heartbeat job k8s pod.
Signed-off-by: Yana Zhivkova yzhivkova@vmware.com