This repository was archived by the owner on Sep 1, 2026. It is now read-only.
[vdk-plugins] Update ingestion interfaces used in plugins - #689
Merged
Conversation
Contributor
doks5
force-pushed
the
person/andonova/update-ingest-interfaces
branch
from
February 1, 2022 15:02
8d3c17a to
190d6cc
Compare
Contributor
Author
|
@ivakoleva I am not sure about the second one, ingestion-file, though. It is already updated, is there something additional that needs to be done? |
ivakoleva
approved these changes
Feb 1, 2022
ivakoleva
left a comment
ivakoleva
left a comment
Contributor
There was a problem hiding this comment.
don't see anything else missing except test_run_ingest.py
doks5
force-pushed
the
person/andonova/update-ingest-interfaces
branch
2 times, most recently
from
February 1, 2022 18:52
e727650 to
dc0222f
Compare
As part of #682, the signature of the ingest_payload() method was updated to accept a metadata object as part of the ingestion flow. Once the interface change is adopted in vdk-core, this would cause data jobs to fail, due to missing keyword argument "metadata". This change updates the signatures of the ingest_payload() methods, implemented in the vdk-plugins that provide ingestion capabilities. This is done in order to avoid the abovementioned error. Testing Done: Not required, as no plugins currently process the metadata. Signed-off-by: Andon Andonov <andonova@vmware.com>
doks5
force-pushed
the
person/andonova/update-ingest-interfaces
branch
from
February 1, 2022 18:54
dc0222f to
4a5bc09
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of #682, the
signature of the ingest_payload() method was updated to accept a metadata
object as part of the ingestion flow.
Once the interface change is adopted in vdk-core, this would cause data jobs to
fail, due to missing keyword argument "metadata".
This change updates the signatures of the ingest_payload() methods, implemented
in the vdk-plugins that provide ingestion capabilities. This is done in order to
avoid the abovementioned error.
Testing Done: Not required, as no plugins currently process the metadata.
Signed-off-by: Andon Andonov andonova@vmware.com