Skip to content
This repository was archived by the owner on Sep 1, 2026. It is now read-only.

pipelines-control-service: redirect Swagger webjars resources - #697

Merged
ivakoleva merged 2 commits into
mainfrom
persin/ikoleva/swagger-webjars-redirect
Feb 8, 2022
Merged

pipelines-control-service: redirect Swagger webjars resources#697
ivakoleva merged 2 commits into
mainfrom
persin/ikoleva/swagger-webjars-redirect

Conversation

@ivakoleva

Copy link
Copy Markdown
Contributor

Swagger UI HTML page is not completely rendered. Cause is,
the resources included in swagger-ui.html that are /webjars/**
were not redirected to /data-jobs.

Path-prefixed the webjars for auth purposes. Redirected
webjars to the new path.

Testing Done: did add an integration test to verify availability of
a webjar expected.

Signed-off-by: ikoleva ikoleva@vmware.com

Swagger UI HTML page is not completely rendered. Cause is,
the resources included in swagger-ui.html that are /webjars/**
were not redirected to /data-jobs.

Path-prefixed the webjars for auth purposes. Redirected
webjars to the new path.

Testing Done: did add an integration test to verify availability of
a webjar expected.

Signed-off-by: ikoleva <ikoleva@vmware.com>

@doks5 doks5 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ivakoleva
ivakoleva merged commit fab98b7 into main Feb 8, 2022
@ivakoleva
ivakoleva deleted the persin/ikoleva/swagger-webjars-redirect branch February 8, 2022 12:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants