This repository was archived by the owner on Sep 1, 2026. It is now read-only.
versatile-data-kit: set automatic java formatter - #757
Merged
Conversation
gabrielgeorgiev1
approved these changes
Mar 10, 2022
ivakoleva
approved these changes
Mar 16, 2022
ivakoleva
left a comment
ivakoleva
left a comment
Contributor
There was a problem hiding this comment.
lgtm, seems the hook will autoupdate to use latest google java formatter, unless pinned to a specific one
antoniivanov
changed the title
antoniivanov
force-pushed
the
person/aivanov/java-style
branch
3 times, most recently
from
April 13, 2022 14:22
d2d3c05 to
34ae85f
Compare
Contributor
Author
|
This is on hold for now because I have not figure out how to apply the pre-commit hook without requiring java to be installed . Java is only required for control service. There are people that have contributed only to the SDK. We should not require them to have java. |
antoniivanov
force-pushed
the
person/aivanov/java-style
branch
3 times, most recently
from
August 23, 2022 20:15
040fc83 to
d002063
Compare
We have settled on using Google Java coding style . This is adding github action to automatically format the code. I nitially wanted to use pre-commit hook (https://github.com/macisamuele/language-formatters-pre-commit-hooks) but it requires to have installed locally java and I could not figuore out how to make it optional for local runs. Signed-off-by: Antoni Ivanov <aivanov@vmware.com>
antoniivanov
force-pushed
the
person/aivanov/java-style
branch
from
August 23, 2022 20:35
327e8f5 to
ad9b8bf
Compare
antoniivanov
changed the title
antoniivanov
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have settled on using Google Java coding style . This is adding
github action to automatically format the code.
I nitially wanted to use pre-commit hook
(https://github.com/macisamuele/language-formatters-pre-commit-hooks)
but it requires to have installed locally java and I could not figuore
out how to make it optional for local runs.
Signed-off-by: Antoni Ivanov aivanov@vmware.com