This repository was archived by the owner on Sep 1, 2026. It is now read-only.
control-service: Set TTLAfterFinished period for K8s CronJobs - #776
Merged
Conversation
Signed-off-by: Gabriel Georgiev <gageorgiev@vmware.com>
Contributor
|
Please make it conifgurable . |
Signed-off-by: Gabriel Georgiev <gageorgiev@vmware.com>
gabrielgeorgiev1
marked this pull request as ready for review
March 23, 2022 10:33
Signed-off-by: Gabriel Georgiev <gageorgiev@vmware.com>
Signed-off-by: Gabriel Georgiev <gageorgiev@vmware.com>
antoniivanov
approved these changes
Mar 23, 2022
Signed-off-by: Gabriel Georgiev <gageorgiev@vmware.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To take advantage of the automatic jobs cleanup afforded by
the TTL Controller, we need to the the TTLAfterFinished setting
to some appropriate value. Here, we've chosen 1 hour.
Testing done: TBD
Signed-off-by: Gabriel Georgiev gageorgiev@vmware.com