This repository was archived by the owner on Sep 1, 2026. It is now read-only.
control-service: upgrade docker container used in cicd - #911
Merged
Conversation
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
added 12 commits
July 25, 2022 13:46
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
mrMoZ1
changed the title
ivakoleva
approved these changes
Jul 25, 2022
mrMoZ1
enabled auto-merge (squash)
July 25, 2022 16:08
mrMoZ1
force-pushed
the
person/mzhivkov/fix-cicd
branch
from
July 26, 2022 07:24
72d4155 to
ff8bac8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what: Upgraded cicd docker image.
why: The cicd (integration tests) were failing because a version with an older jdk was used in the container. Container couldn't install a newer jdk version, even though we tried various ways of pinning the dependency. Only a newer docker allowed us to do this.
testing: integration test
Signed-off-by: Momchil Zhivkov mzhivkov@vmware.com