Skip to content
This repository was archived by the owner on May 18, 2026. It is now read-only.

Show supply chain info in workload get#119

Merged
rashedkvm merged 3 commits into
vmware-tanzu:mainfrom
warango4:issue61-supplychain
May 20, 2022
Merged

Show supply chain info in workload get#119
rashedkvm merged 3 commits into
vmware-tanzu:mainfrom
warango4:issue61-supplychain

Conversation

@warango4
Copy link
Copy Markdown
Contributor

Pull request

What this PR does / why we need it

In this feat, the way the workload status used to be displayed changes to show specifically the supply chain info (name) and the workload status on its Ready condition.
If there is no supply chain reference, but there is a Ready condition that surfaces the workload status, on row "name", <none> is going to be displayed.
If there is no Ready condition, but a supply chain reference, then rows "ready" and "last update" are left blank.
If there are no conditions and no supply chain reference, a message indicating this situation is displayed.

Which issue(s) this PR fixes

Fixes #61

Describe testing done for PR

  • Unit testing
  • Used command in local cluster

Additional information or special notes for your reviewer

Follow-up of PR #99 for issue #61

Signed-off-by: Wendy Arango warango@vmware.com

In this feat, the way the workload status used to be displayed changes to show specifically the supply chain info (name) and the workload status on its Ready condition.
If there is no supply chain reference, but there is a Ready condition that surfaces the workload status, on row "name", `<none>` is going to be displayed.
If there is no Ready condition, but a supply chain reference, then rows "ready" and "last update" are left blank.
If there are no conditions and no supply chain reference, a message indicating this situation is displayed.

Follow-up of PR vmware-tanzu#99 for issue vmware-tanzu#61

Signed-off-by: Wendy Arango <warango@vmware.com>
@warango4 warango4 force-pushed the issue61-supplychain branch from 0e2eeb0 to 65ddfd7 Compare May 17, 2022 21:45
@warango4
Copy link
Copy Markdown
Contributor Author

No supply chain matching workload labels

image

@warango4
Copy link
Copy Markdown
Contributor Author

image

@warango4
Copy link
Copy Markdown
Contributor Author

image

@warango4
Copy link
Copy Markdown
Contributor Author

image

Comment thread pkg/commands/workload_get.go
Comment thread pkg/printer/workload_status_printer_test.go
Comment thread pkg/printer/workload_status_printer.go
@warango4 warango4 force-pushed the issue61-supplychain branch from ba2f4c8 to ddc1842 Compare May 19, 2022 05:11
@warango4 warango4 requested a review from shashwathi May 19, 2022 17:34
@rashedkvm rashedkvm merged commit fcb6c0a into vmware-tanzu:main May 20, 2022
@warango4 warango4 deleted the issue61-supplychain branch July 14, 2022 13:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add supply chain status information to workload get

4 participants