🌟 enhancement(VSecM): pointed example images to upstream #1093
+7
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update example image overrides to refer from the "latest" tag on upstream instead of "localhost:5000". This will allow people to follow the use cases and other examples in the documentation easier as they won't have to build the project from source and also they won't need to update the version numbers. Since the version numbers in the repository often points to a future version that has not been published yet, trying to install them without updating the image-overrides was causing "image not found" errors. This PR addresses that by always pointing the example images to the `latest` upsream version. Since these examples often do not change and are mature enough, it does not quite matter where you pull them from as long as you can download and install them. This PR does not change other product images and image overrides, it only affect the image overrides under the `./examples` folder. Signed-off-by: Volkan Özçelik <volkan.ozcelik@broadcom.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update example image overrides to refer from the "latest" tag on upstream instead of "localhost:5000". This will allow people to follow the use cases and other examples in the documentation easier as they won't have to build the project from source and also they won't need to update the version numbers.
Since the version numbers in the repository often points to a future version that has not been published yet, trying to install them without updating the image-overrides was causing "image not found" errors. This PR addresses that by always pointing the example images to the
latestupsream version.Since these examples often do not change and are mature enough, it does not quite matter where you pull them from as long as you can download and install them.
This PR does not change other product images and image overrides, it only affect the image overrides under the
./examplesfolder.