Skip to content

Conversation

@Doguhannilt
Copy link
Contributor

Title of the Pull Request

test(service) testing saveToFileService and WatchService

Description

Testing service/SaveToFileService and service/WatchService files with Junit and Mockito.

Changes

List the major changes you have made in bullet points:

  • service/SaveToFileService is tested in SaveToFileServiceTest
  • service/WatchService is tested in WatchServiceTest
  • Mockito (Version 5.14.2) Junit (Version 5.9.2) Awaitility (Version 4.2.0) added to Pom.xml

Test Policy Compliance

  • I have added or updated unit tests for my changes.
  • I have included integration tests where applicable.
  • All new and existing tests pass successfully.

Code Quality

  • I have followed the coding standards for this project.
  • I have performed a self-review of my code.
  • My code is well-commented, particularly in areas that may be difficult
    to understand.

Documentation

  • I have made corresponding changes to the documentation (if applicable).
  • I have updated any relevant READMEs or wiki pages.

Additional Comments

Include any additional comments or context about the PR here.

Checklist

Before you submit this PR, please make sure:

  • You have read the contributing guidelines and
    especially the test policy.
  • You have thoroughly tested your changes.
  • You have followed all the contributing guidelines for this project.
  • You understand and agree that your contributions will be publicly available
    under the project's license.

By submitting this pull request, you confirm that my contribution is made under
the terms of the project's license and that you have the authority to grant
these rights.


Thank you for your contribution to VMware Secrets Manager
🐢⚡️!

Signed-off-by: doguhannilt <doguhannilt@gmail.com>
@Doguhannilt Doguhannilt requested a review from BulldromeQ as a code owner March 6, 2025 21:53
Signed-off-by: doguhannilt <doguhannilt@gmail.com>
Copy link
Contributor

@v0lkan v0lkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@v0lkan v0lkan merged commit 4120644 into vmware:main Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants