control-service: Add username to executions - #159
Merged
Conversation
doks5
force-pushed
the
person/andonova/improve-execute-ux3
branch
from
August 31, 2021 07:54
7bbe7cb to
13a6fc9
Compare
doks5
force-pushed
the
person/andonova/improve-execute-ux3
branch
from
August 31, 2021 14:34
13a6fc9 to
8d9cafc
Compare
antoniivanov
approved these changes
Sep 1, 2021
mivanov1988
approved these changes
Sep 1, 2021
doks5
force-pushed
the
person/andonova/improve-execute-ux3
branch
from
September 1, 2021 15:28
8d9cafc to
5d78022
Compare
As part of improving the user experience when doing manual job executions, and troubleshooting failed executions, we need to be able to tell by whom was an execution started. This change adds the username of the user, who has initiated an execution, to the startedBy annotation. Testing Done: Updated existing unit test to reflect the change. Signed-off-by: Andon Andonov <andonova@vmware.com>
doks5
force-pushed
the
person/andonova/improve-execute-ux3
branch
from
September 1, 2021 16:01
5d78022 to
16046a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of improving the user experience when
doing manual job executions, and troubleshooting
failed executions, we need to be able to tell by
whom was an execution started.
This change adds the username of the user, who has
initiated an execution, to the startedBy annotation.
Testing Done: Updated existing unit test to reflect the
change.
Signed-off-by: Andon Andonov andonova@vmware.com