control-service: add last execution info to the data_job table - #480
Merged
Conversation
As part of preparation for the implementation of the ability to filter and sort data jobs by their last execution status, time, and duration, add the respective columns to the data_job table. Testing done: Start the service and verify that the columns are created in the data_job table. Signed-off-by: Tsvetomir Palashki <tpalashki@vmware.com>
mivanov1988
reviewed
Nov 5, 2021
Signed-off-by: Tsvetomir Palashki <tpalashki@vmware.com>
mivanov1988
approved these changes
Nov 5, 2021
The H2 database used when running tests fails if the new three columns are added all at once. Change the flyway script to add the columns one by one. Testing done: running locally against an in-memory H2 database and verified that the script is run successfully. Signed-off-by: Tsvetomir Palashki <tpalashki@vmware.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of preparation for the implementation of the ability to filter
and sort data jobs by their last execution status, time, and duration,
add the respective columns to the data_job table.
Testing done: Start the service and verify that the columns are created
in the data_job table.
Signed-off-by: Tsvetomir Palashki tpalashki@vmware.com