control-service: Update the GraphQL model with the last execution - #486
Merged
Conversation
Extended the GraphQL and service models to reflect the properties that were added as part of the implementation of the ability to sort and filter data jobs by their last execution status, time, and duration. Wire the two models so that the newly added properties can be queried via GraphQL. Testing done: Run the service locally and verified that the new properties are returned when requested. Signed-off-by: Tsvetomir Palashki <tpalashki@vmware.com>
Contributor
|
LGTM: do we have any tests for this? |
Contributor
Author
|
I haven't added tests yet as it is mostly plumbing code. I will cover when I have the actual implementation of the filtering/sorting in place. |
Contributor
Yes, but since it is possible to adopt it in production it may be a good idea to add some. |
Signed-off-by: Tsvetomir Palashki <tpalashki@vmware.com>
mivanov1988
approved these changes
Nov 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extended the GraphQL and service models to reflect the properties that were added
as part of the implementation of the ability to sort and filter data jobs by their
last execution status, time, and duration.
Wire the two models so that the newly added properties can be queried via GraphQL.
Testing done: Run the service locally and verified that the new properties are
returned when requested.
Signed-off-by: Tsvetomir Palashki tpalashki@vmware.com