control-service: add IT for graphQL sort, filter by next run - #564
Merged
Conversation
doks5
approved these changes
Nov 29, 2021
doks5
left a comment
doks5
left a comment
Contributor
There was a problem hiding this comment.
I have only one comment, so, overall, LGTM.
added 2 commits
November 30, 2021 18:42
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
mrMoZ1
force-pushed
the
person/mzhivkov/sort-next-run
branch
from
November 30, 2021 16:44
24f4934 to
74c6ac7
Compare
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
mrMoZ1
force-pushed
the
person/mzhivkov/sort-next-run
branch
from
December 1, 2021 08:25
c4437e2 to
fbc603c
Compare
added 2 commits
December 1, 2021 11:05
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
mrMoZ1
force-pushed
the
person/mzhivkov/sort-next-run
branch
from
December 1, 2021 09:54
43e44c6 to
df52fa6
Compare
added 2 commits
December 1, 2021 13:54
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
mrMoZ1
pushed a commit
that referenced
this pull request
Dec 6, 2021
why: Users requested additional sorting functionality. We need to add sort on next run in the graphQl API. The change should be implemented in the back-end. what: Change is already implemented. Added IT test that verifies it and informs us of any bugs. testing: Added new test. Signed-off-by: Momchil Zhivkov mzhivkov@vmware.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
why: Users requested additional sorting functionality.
We need to add sort on next run in the graphQl API.
The change should be implemented in the back-end.
what: Change is already implemented. Added IT test
that verifies it and informs us of any bugs.
testing: Added new test.
Signed-off-by: Momchil Zhivkov mzhivkov@vmware.com