builds: make pre-requisites explicit - #61
Merged
Merged
Conversation
First time building of the project locally start from running ./cicd/build.sh . It's good idea to also check for any pre-requisites required in order to buld all components. I think that the top level build should not try to build different projects. Each project should be independant of all other projects (as if they were in different git repo). This would enfore keeping them decoupled from each other (no build time dependencies) and facilitate easer parallel development (people devloping on vdk-core would not impact those making changes in control-service. Testing Done: In empty env (using docker): docker docker run -it -v "$(pwd):/vdk" ubuntu /bin/bash ./cicd/build.sh - prompted to install python and warn me for missing java After installing conda - was able to run ./cicd/build.sh succesfully Then ran vdk-core and vdk-control-cli build succesfully. control-service build is failing currently and this will be fixed separately.
ivakoleva
approved these changes
Aug 10, 2021
ivakoleva
left a comment
Contributor
There was a problem hiding this comment.
So root/cicd/build.sh is used to mainly check prerequisites, and print what you need to do next in plaintext;
I am okay with that - I would also be okay if root is able to build everything at once - just to have this enabled if someone wants to rebuild all the components altogether.
About the main build.sh output, again it seems useful for each component contextual ./cicd/build.sh, to be runnable from anywhere - without user changing directories explicitly. It's more convenient, and fail-prone.
I also did build each component successfully, using the build scripts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First time building of the project locally start from running
./cicd/build.sh . It's good idea to also check for any pre-requisites
required in order to buld all components.
I think that the top level build should not try to build different
projects. Each project should be independant of all other projects (as
if they were in different git repo). This would enfore keeping them
decoupled from each other (no build time dependencies) and facilitate
easer parallel development (people devloping on vdk-core would not
impact those making changes in control-service.
Testing Done: In empty env (using docker):
docker docker run -it -v "$(pwd):/vdk" ubuntu /bin/bash
./cicd/build.sh - prompted to install python and warn me for missing
java
After installing conda - was able to run ./cicd/build.sh succesfully
Then ran vdk-core and vdk-control-cli build succesfully.
control-service build is failing currently and this will be fixed
separately.