Skip to content

Conversation

@Shatur
Copy link

@Shatur Shatur commented Aug 28, 2021

Added the same check as in generate_engine_classes_bindings.

I also added skip for XRInterfaceGDNative and XRInterfaceGDNative to fix build on the latest master.

@Shatur Shatur changed the base branch from master to gdnative-extensions August 28, 2021 14:19
@vnen
Copy link
Owner

vnen commented Aug 31, 2021

I also added skip for XRInterfaceGDNative and XRInterfaceGDNative to fix build on the latest master.

Why are those needed? The ClassDB has an issue because GodotCPP has its own ClassDB so it conflicts with the generated one from Godot. It shouldn't happen with other classes.

@Shatur
Copy link
Author

Shatur commented Aug 31, 2021

Why are those needed? The ClassDB has an issue because GodotCPP has its own ClassDB so it conflicts with the generated one from Godot. It shouldn't happen with other classes.

@vnen Hm... I double checked and you are right, it works without it. Probably cache was messed because I sent this before CMake fixes.
Removed, should be good now.

@vnen vnen merged commit ec6ace3 into vnen:gdnative-extensions Sep 1, 2021
@vnen
Copy link
Owner

vnen commented Sep 1, 2021

Thanks!

@Shatur Shatur deleted the fix_print_file_list branch September 1, 2021 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants